Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve readme for contributor experience #36817

Merged
merged 3 commits into from Nov 18, 2016
Merged

improve readme for contributor experience #36817

merged 3 commits into from Nov 18, 2016

Conversation

sebgoa
Copy link
Contributor

@sebgoa sebgoa commented Nov 15, 2016

What this PR does / why we need it:

This improves the top-level README. Removes broken links, removes links to make you bounce to another page, adds proper links to docs.
Shuffles things around a bit and improves reading.

@kubernetes/contributor-experience


This change is Reviewable

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Nov 15, 2016
@metral
Copy link
Contributor

metral commented Nov 15, 2016

This PR removes links to external community efforts around k8s, e.g. Awesome-Kubernetes & CoreKube etc. - (I started CoreKube).

Is it worth it to place these efforts in a separate page dedicated for community resources as folks still find these sorts of efforts helpful?

/cc @bgrant0607 @sarahnovotny

@sebgoa
Copy link
Contributor Author

sebgoa commented Nov 15, 2016

To plead my case, as I mentioned on twitter, I was doing a review of the README and when I hit the bottom I saw those links. CoreKube is really nice but the collections page is empty.

I pondered a lot on what to do with them, and then decided to remove them.

I think they would be better on the website. there is a big community page that needs lots of love. There is also a big Tools page that needs love as well.

@metral
Copy link
Contributor

metral commented Nov 15, 2016

Makes total sense 👍 .

I'll defer to Brian or Sarah to suggest a more appropriate home for these sorts of pages.

@bgrant0607
Copy link
Member

cc @kubernetes/docs

@bgrant0607 bgrant0607 added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Nov 15, 2016
@bgrant0607
Copy link
Member

bgrant0607 commented Nov 15, 2016

Copying from slack:

I don't think we should link to community resources from kubernetes/README.md. We should find a place on kubernetes.io for them.

Files to remove:

Kubernetes is an open source system for managing [containerized applications](https://github.com/kubernetes/kubernetes/wiki/Why-Kubernetes%3F#why-containers) across multiple hosts,
providing basic mechanisms for deployment, maintenance, and scaling of applications.
Kubernetes is an open source system for managing [containerized applications](http://kubernetes.io/docs/whatisk8s/) across multiple hosts,
providing basic mechanisms for deployment, maintenance, and scaling of applications. Kubernetes is hosted by the Cloud Native Computing Foundation ([CNCF](https://www.cncf.io))

Kubernetes is:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these bullets.


<hr>

### Kubernetes is ready for Production !
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just remove this subsection.


Since the Kubernetes 1.0 release in July 2015 Kubernetes is ready for your production workloads. Check the [case studies](http://kubernetes.io/case-studies/).

### Kubernetes can run anywhere !
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just remove this subsection.

### Are you ...

* Interested in learning more about using Kubernetes? Please see our user-facing documentation on [kubernetes.io](http://kubernetes.io). Try our [interactive tutorial](http://kubernetes.io/docs/tutorials/kubernetes-basics/) or take a free course on [Scalable Microservices with Kubernetes](https://www.udacity.com/course/scalable-microservices-with-kubernetes--ud615).
* Interested in hacking on the core Kubernetes code base, developing tools using the Kubernetes API or helping in anyway possible ? Keep reading!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or helping with the project


## Concepts
## Concepts Overview
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this subsection.


Kubernetes documentation is organized into several categories.
Do you want to help " shape the evolution of technologies that are container packaged, dynamically scheduled and microservices oriented? ". If you are a company, you should consider joining the [CNCF](https://cncf.io/about). For details about who's involved and how Kubernetes plays a role, read [the announcement](https://cncf.io/news/announcement/2015/07/new-cloud-native-computing-foundation-drive-alignment-among-container).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

container-packaged
microservices-oriented

English is right-associative.

### Are you ready to add to the discussion?

We have presence on:
Join us on social media and read our blog:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to link to kubernetes.io (e.g., http://kubernetes.io/community/) and keep this simpler. If some of this info isn't easily found there, we should fix that.


If you're interested in being a contributor and want to get involved in developing Kubernetes, start in the [Kubernetes Developer Guide](docs/devel/README.md) and also review the [contributor guidelines](CONTRIBUTING.md).
* [kubecon](http://events.linuxfoundation.org/events/kubecon)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I don't see info about kubecon on kubernetes.io. That would be useful to fix.


While there are many different channels that you can use to get ahold of us, you can help make sure that we are efficient in getting you the help that you need.
* The community [expectations](docs/devel/community-expectations.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelleN We'll need to update these links when the developer docs are moved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do


### Community resources
## Documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a link to the doc site above, so I think we can just remove this section.

@bgrant0607
Copy link
Member

Thanks for the cleanup, @sebgoa!

@sebgoa
Copy link
Contributor Author

sebgoa commented Nov 15, 2016

Ok addressed all comments.

I kept some links in the community section, just made it a bit more compact. I will make sure to revisit once the kubernetes.io/community page gets in a better state.

Ideally I would like to add a simple build section once I get passed #36655 , showing how you can build k8s in two bash commands will be powerful.

@sebgoa
Copy link
Contributor Author

sebgoa commented Nov 15, 2016

I think we could also remove code-of-conduct.md since it is now a link to cncf. I am linking directly to it in the readme.

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit db98a18. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@bgrant0607
Copy link
Member

@sebgoa code-of-conduct.md is currently part of the repo template. If we remove it here, we should make a similar change to the template. philips may have an opinion on that.

@bgrant0607
Copy link
Member

@bgrant0607
Copy link
Member

LGTM other than the check failures.

@sebgoa
Copy link
Contributor Author

sebgoa commented Nov 17, 2016

ok tests are passing now. hadn't run munge-docs so fixed some broken links in docs/ docs/devel and examples/ folders.

@bgrant0607
Copy link
Member

@saad-ali Would you mind if this were merged now?

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2016
@saad-ali
Copy link
Member

@saad-ali Would you mind if this were merged now?

Doc changes are ok for post-code-freeze merge.

@saad-ali saad-ali added this to the v1.5 milestone Nov 18, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 5143bae into kubernetes:master Nov 18, 2016
@sebgoa sebgoa deleted the readme branch November 18, 2016 08:30
@philips
Copy link
Contributor

philips commented Nov 22, 2016

I am fine with the code-of-conduct move. I will do the same for the template project.

xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
Automatic merge from submit-queue

improve readme for contributor experience

**What this PR does / why we need it**:

This improves the top-level README. Removes broken links, removes links to make you bounce to another page, adds proper links to docs.
Shuffles things around a bit and improves reading.

@kubernetes/contributor-experience
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants